Chris Sewell

Results 1295 comments of Chris Sewell
trafficstars

@jayaddison @AA-Turner I'm not sure what you are talking about here; we already have adopted autoformatting 😅 Every "new" file added will already be formatted, and if you want to...

> When you have time, could you have a look at this one? > but I don't mind you to take your time (I'll be away for a few weeks)....

Sorry but I am very -1 against this, I don't think you should be enforcing ad-hoc formatting rules, that touch nearly every file of the project, whilst blocking an actual...

> but nevertheless I'm happy to close and revisit this later if you'd prefer. thanks for explaining; I'm mean, the irony is that I am definitely in favor of this...

Hey all, I have a slightly different solution to propose #12507 🙃 see: https://sphinx--12507.org.readthedocs.build/en/12507/usage/restructuredtext/directives.html#directive-note As the author/maintainer of https://sphinx-design.readthedocs.io/en/furo-theme/dropdowns.html, if this was merged, I would in a heartbeat basically deprecate...

Let's say yes cheers, and can always re-open if necessary

I think what you are describing is basically https://doc.rust-lang.org/reference/visibility-and-privacy.html 😄, but an "inversion" (i.e. public by default, instead of private), which is good 👍 > each module uses `__all__` to...

> tactually i think it main use case was originally controlling the behaviour of glob imports. But it's now used also used for defining public interfaces and also explicit re-exports,...

@electric-coder I think you missed the point of what I said; I specifically said you can use `__all__` for re-exports, i.e. to make private objects public, but what you can't...

> Hadn't looked at it yet but you might need to fix the `ColorizeFormatter` of the logging module as well this looks ok to me, basically it ends up calling:...