Chris Sewell
Chris Sewell
> I don't really like that. Instead, I should add some documentation for that. Otherwise, everytime a new dependency is added, a new import-guard should be added and it's an...
> Finally, using `tox` would technically be sufficient if we had updated our other packages to actually use `dev` I still feel this misses the point a little though 😅...
> I'm always open to suggestions so I don't mind the debate! 😄 👍 > because I really don't expect people to get into the pyproject.toml file maybe just me,...
(Also added a docstring for the `Sphinx.__init__`)
Heya, as per #12089, could you change your initial comment, to be more specific about what issues this PR proposes to fix, and how it proposes to fix them
> you introduced the typed interface for that one so perhaps you could take that one? Well, that's one of the reasons I introduced it; because for a long time...
> This kinda says the opposite well that is not consistent with what the actual source says: https://github.com/sphinx-doc/sphinx/blob/6fd8b3004315f56b4464d9426829f7643e7b7bc1/sphinx/domains/__init__.py#L159-L180 > And it's not only about storing data, it's also about making...
Oh I forgot there is something more in-line with what you want: https://github.com/sphinx-doc/sphinx/blob/5562e2b032820043ce75ee8645fe0d8e2bbf4d11/sphinx/environment/collectors/__init__.py#L14 and can be added with https://github.com/sphinx-doc/sphinx/blob/5562e2b032820043ce75ee8645fe0d8e2bbf4d11/sphinx/application.py#L1221 you see it just links methods to event hooks though, ao...
@AA-Turner given #12335 and #12337 I would like to revisit this, and just make a final decision either way 😅 From my understanding, I believe many active maintainers are in...
> I'm cautiously in favour of doing this, but perhaps we should delay for a while (a month?) to ensure that any further 7.3.0 issues are tracked down before doing...