Christian Duerr

@sethm I haven't looked at the code myself, so use at your own risk, but you might be interested in https://github.com/alacritty/alacritty/pull/8560.

> I'm not sure how to trigger the benchmarks bot. You can't. I did.

@boazy This has stalled out for a while now, are you still interested in working on this? I'm slightly concerned because the longer we wait, the higher the chance that...

Just to recap because this is quickly fading into obscurity and I don't want to forget about it entirely: Splitting `opaque_start` up would be no problem, since we have access...

> I honestly don't know. I assumed the size is important for performance since we want to be able to have all state transitions in one table (which only has...

Going it tenatively approve the current revision, I don't think there's any other changes necessary from your end. While I'm not entirely convinced I'll give this a closer look and...

@boazy Just a heads-up: Once https://github.com/alacritty/vte/pull/118 is merged, it might make some sense to reinvestigate this. There's certainly been some changes and we do have a lot of extra free...

Just to be clear on this: > [sos/apc/pm]_dispatch() is called individually for each byte. For any use case which is not a byte-by-byte parser, it would probably be more efficient...

> On a second thought, I'm not sure if buffering opaque sequences will be such a great boon for clients of VTE anyway. Just like VTE itself is inlining methods,...

Added some small comments, but didn't want to actually do a review yet. Please just re-request one once you think you're done with your changes.