Christian Schlotter

/lgtm /approve pending ci

/remove-lifecycle stale

Taking this one - [ ] P1: Let's check if we have unit test coverage for the following tests for supervisor

I created a PR for > - [ ] P1: Let's check if we have unit test coverage for the following tests for supervisor @chrischdi > * capv-e2e.[It] Label nodes...

> @chrischdi Whoever takes [Prepare main branch for development of the new release](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/docs/release/release-tasks.md?rgh-link-date=2024-04-25T12%3A27%3A27Z#prepare-main-branch-for-development-of-the-new-release), let's take the chance to finalize the corresponding doc section after we finalized what exactly we have...

All PR's for v1.31 should be prepared now. Waiting for the v1.31.0 release.

So should we close this one?

/lgtm /approve /hold in case you want to wait / give @fabriziopandini another look. But I think its good enough to re-iterate next time :-)

A different approach would be to make it more easy to discover this issue / bring up a condition or so at the VSphereCluster object, that the object does not...

Just adding a finaliser could still lead to users deleting the `VirtualMachineService`. They still can use `kubectl delete --force --grace-period=0` to delete the object, or `kubectl delete` + remove the...