Christian Schlotter
Christian Schlotter
Opening up for review. I suggest to postpone documentation to a second PR after merging this. Also added an integration test. I think this could greatly get built out to...
I know this PR is huge and will take time for review. I tried to get to a good code coverage via unit / integration testing. Kindly asking @mrueg @fpetkovski...
Note: if there are questions regarding ownership/maintenance of the code: I'd be happy to help on reviews for changes on this new codebase.
@CatherineF-dev , kindly asking for another round of review :-) I think this last push should address the open comments if I'm right.
> @CatherineF-dev , kindly asking for another round of review :-) I think this last push should address the open comments if I'm right. @CatherineF-dev , friendly ping :-) Happy...
Thanks @mrueg for the review, also thanks @dgrisonnet for letting me know. Also sorry for the long time I required to get this back on track and rebased. I also...
Hey folks, happy to drive this further or shutdown the PR if its not reasonable to get added.
> Hey, thank you for working on this. Just a question right off the top of my mind, would this be better suited to be in a KSM _operator_? I...
I like the idea of cleaning up the configuration. When doing so we should take care that we are still able to address all use-cases which got addressed currently. IMHO:...
One point which came to my mind we should consider if this gets done: performance!