chase isabelle comments

Results 7 comments of


                                            chase isabelle

gin server append error with c.Error() instead of dumping it with c.JSON()

I would like to submit a PR for this, but it appears I don't have rights: ``` $ git push origin gin-error-handler-option ERROR: Permission to deepmap/oapi-codegen.git denied to chase-isabelle-roostify. fatal:...

gin server append error with c.Error() instead of dumping it with c.JSON()

@deepmap-marcinr thank you! i've added my pr, please have a look when you have a moment. https://github.com/deepmap/oapi-codegen/pull/587

gin server append error with c.Error() instead of dumping it with c.JSON()

I managed to mitigate this issue using custom templates: https://github.com/deepmap/oapi-codegen#making-changes-to-code-generation

gin server custom error handler option

Well, the error is what the handler is handling, so it seems superfluous to return it back to the caller. Or am I misunderstanding what you mean?

gin server custom error handler option

@deepmap-marcinr Sorry to bug ya. Was just wondering if these changes might be good to go?

gin server custom error handler option

I've managed to mitigate this with custom templates: https://github.com/deepmap/oapi-codegen#making-changes-to-code-generation

AdditionalProperties behavior differences

Same. I took a note from @lzap and added this perl command to my `Makefile`, runs against my generated `yaml`: ``` docker run --rm -it -w /workdir -v ${PWD}:/workdir perl:latest...