cepetr

Results 9 comments of cepetr

I have to admit this PR is more about my personal preference that rational reasons. That's just the way it is:-) I hoped to find allies in this. If not,...

Finally, I found the `clang-format` settings that ensure function declaration and calling arguments are placed on separate lines if they do not fit on a single line. The following settings...

Adding `PenaltyIndentedWhitespace: 1000` reduces alignment overall. That relatively new parameter might be exactly what I was looking for all along. It eliminates unnecessary alignment at the beginning of lines, making...

> @cepetr could you please update this PR so we can see the resulting changes and discuss whether this would be OK for all? No rush, whenever you feel like...

After discussing this matter with @TychoVrahe today, I’ve decided to close it. Unfortunately, it seems there isn’t a viable way to strike a balance between what we want, the value...

> The weird definition and usage of `ensure` with multiplication which was made against being removed by compiler and generated better barrier assembler code. Hamming weight of `sectrue` and `secfalse`...

Yes, that seems to be a system problem. Currently, the kernel itself is not aware of `usb_vcp`, as it is now initialized by the unprivileged app via a syscall. We...

> one more commit to: fix caching of potentially non-written public keys, and prioritize locked bootloader check in prepare_fw function: [6e8ed49](https://github.com/trezor/trezor-firmware/commit/6e8ed491d29b59a391dd7f90282aac08cff7b5b7) LGTM

- storage initialization resolved in #5394 - usb syscalls resoved in #5541 - display/bitblt validation added in #4683