cccs-jc

Results 21 comments of cccs-jc
trafficstars

That's great. The parts I was thinking would make sense to integrate into juypterlab-lsp are the configurations. Specifically in this section https://github.com/CybercentreCanada/jupyterlab-sql-editor#configure-sql-language-server-startup-scripts This file registers the language server along with...

I like how the https://github.com/jupyter-lsp/json-lsp registers it's language spec. It looks like will execute the python code that registers the spec. I need this because sql-language-server is a node process...

Ha interesting once again. So `data_files` is a means to install files in your python setup process. My background is in Java so Python/Typescript is a bit new to me....

I have tried to add to the overrides.d, however this looks to be a new feature not release yet. Correct? https://github.com/jupyterlab/jupyterlab_server/issues/223 What alternative do I have while this new feature...

According to this code the place to drop files in overrides.d would actually be ``` share/jupyter/lab/settings/overrides.d ``` correct? I did that but still it's not being picked by JupyterLab. Any...

I've got it to work with the proposed solution of data_files https://github.com/CybercentreCanada/jupyterlab-sql-editor/blob/1dab518641a79e07ec8da4abaf491c7f6621b619/setup.py#L28 I will soon publish the package to Pypi and then get in touch to how best make a...

The package is on pypi https://pypi.org/project/jupyterlab-sql-editor/ @krassowski on what page could we reference this LSP server within jupyterlab-lsp thanks

thanks @JulianSMoore I've notice that as well. Since I switch to using a python launch script pressing F5 restarts the LSP server which is better than nothing. Not sure it...

Thanks @krassowski , adding the codemirror dependency got rid of my error. There is still a small snag in the package. ``` node_modules/@krassowski/jupyterlab-lsp/lib/virtual/document.d.ts:3:31 - error TS2307: Cannot find module 'lsp-ws-connection/src'...

I figured out the issue. I had to declare that I want to use the tokens from jupyterlab-lsp and not get a copy of them. That's what I gather anyways....