Carlos Alberto Cortez

Results 218 comments of Carlos Alberto Cortez
trafficstars

Hey @bobstrecansky - the TC is looking for a PHP expert, and hopefully we will find one soon so the review takes place in the following weeks. Otherwise, I have...

Hey @bobstrecansky - I will be doing a review of the PHP API/SDK next week. I will be mostly providing a general review but that should be helpful with the...

@bobstrecansky I started filling issues in the PHP repo after my review - observe most of them are recommendations and can be discarded if the maintainers decide so.

Hey @yurishkuro Added sampling scenarios that may throw light into how useful this feature could be. Please review.

Defined a P1 priority initially (from the maintainers call). @jpkrohling any opinion?

I suggest we have the discussion regarding the naming ("is remote or not") as part of making this into the Specification (where we will have to update the proto files...

@open-telemetry/specs-approvers We have enough approvals so I will merge in the next couple of days. Please raise your voice if you want to do a review before that.

@axw We are ready to merge, but we need to get the lint check to pass. Can you check what's happening? https://app.circleci.com/pipelines/github/open-telemetry/oteps/1593/workflows/eadc0058-1700-47a1-b96a-60abff61c475/jobs/2588

Merged. Please start preparing the PR(s) to include this change in the Spec + proto repositories.

Is this solved as #2854 was closed as well? @jmacd @MrAlias @jack-berg