community icon indicating copy to clipboard operation
community copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Requesting TC review for PHP Tracing API/SDK spec compliance

Open bobstrecansky opened this issue 2 years ago • 6 comments
trafficstars

Requesting a compliance review from https://github.com/orgs/open-telemetry/teams/technical-committee prior to GA release. If there are questions you can ask myself or any of the other PHP maintainers (@brettmc or @pdelewski)

bobstrecansky avatar Apr 14 '23 13:04 bobstrecansky

Hey @bobstrecansky - the TC is looking for a PHP expert, and hopefully we will find one soon so the review takes place in the following weeks. Otherwise, I have volunteered to do a general pass myself.

carlosalberto avatar Apr 26 '23 15:04 carlosalberto

Hey @bobstrecansky - I will be doing a review of the PHP API/SDK next week. I will be mostly providing a general review but that should be helpful with the API/SDK surface at the very least ;)

carlosalberto avatar May 04 '23 17:05 carlosalberto

Perfect; thank you for the update @carlosalberto !

bobstrecansky avatar May 04 '23 18:05 bobstrecansky

@bobstrecansky I started filling issues in the PHP repo after my review - observe most of them are recommendations and can be discarded if the maintainers decide so.

carlosalberto avatar Jun 01 '23 14:06 carlosalberto

Thank you @carlosalberto! Appreciate the review!

bobstrecansky avatar Jun 02 '23 09:06 bobstrecansky

@carlosalberto I think this can be closed as done now, as all of the issues have been actioned and closed: https://github.com/open-telemetry/opentelemetry-php/issues?q=is%3Aissue+author%3Acarlosalberto+label%3Atc-review

brettmc avatar Jul 19 '23 04:07 brettmc