Carl Meyer

Results 203 comments of Carl Meyer
trafficstars

Yeah, that's a reasonable thought. I'm a little hesitant to have MonkeyType do that by default, though, since `from __future__ import annotations` can be a breaking change (if your code...

I don't think it's _easy_, but it should be doable. I still have some mixed feelings about MonkeyType doing that, but I think I would accept a PR for it....

If you want to use `from __future__ import annotations` in your project, I would suggest just adding it to all files in your project once (this is pretty easy to...

Hi! Thanks for the report. I'm afraid that Python is so dynamic it's impossible to know that we've covered every case in type tracing, and "failed collecting trace" warnings are...

Filed #245 to improve output of trace collection failure warnings; thanks for the suggestion.

If the code that you run under MonkeyType tracing passes in a `Runner` instance for the `runner` arg, then it should be annotated as `runner: Runner` by MonkeyType. If that's...

This is a nice idea, and in principle I'm fine with it, but it seems like it will require some work to figure out the organizational permissions to the repo...

Did another more careful run-through, this looks pretty good to me. In an ideal world I'd prefer to bump the test coverage up a bit; a number of the new...

I agree this deprecation is unpleasant, but I still think it might be the best option available. The transition pain is short term; the more important question is which long-term...

@rhettinger Yeah, makes sense. I would love to just rip out the locking functionality without deprecation (since my guess is that few if any users of `cached_property` actually depend on...