Caleb Schoepp

Results 122 comments of Caleb Schoepp

I also have a need to pass config options to the shim. Specifically I want to be able to set the environment variables `RUST_LOG` and `OTEL_EXPORTER_OTLP_ENDPOINT` for the Shim. As...

> fwiw, I did some investigation on adding opentelemtry and tracing to runwasi: https://github.com/containerd/runwasi/issues/10, so the last point about converting all upstream projects to use tracing isn't far fetched and...

> Does that mean we could surface some of the shim logs (which are runtime logs, some that might be very useful when debugging _apps_) to the pod logs? Yes,...

@jsturtevant That's an interesting idea, but I don't think it is actually any different in the end. From reading the docs it appears that `init` is just a convenience wrapper...

After some reflection and conversation with @radu-matei I've decided that the most straightforward way to land o11y support in SpinKube is by disabling the `tracing-log` feature in upstream crates. I'll...

o11y support has landed in the shim so I'm closing this. Config work is being tracked [here](https://github.com/spinkube/spin-operator/issues/253).

Thanks for clarifying @mladedav. If the implementation always returns true for `enabled` then could we just delete the method and use the default implementation that also always returns true? Same...

Thanks again for the very thorough reply @mladedav. I'm happy for this issue to be closed unless you want to track the potential work you mentioned at the end of...

> I really love the name `spintainer` but it's not totally intuitive what it is. Giving it a cute name makes it sound like it's something more than just a...

Comments addressed — looking for some approvals.