Caleb Schoepp comments

Results 122 comments of


                                            Caleb Schoepp

Add support for selective deployments in the spintainer executor

It'd be nice, but I wouldn't say we need to block for it.

Feedback on breaking API changes

Thanks for the feedback @jandubois. We certainly want to avoid making breaking changes going forward. Certainly if we make a breaking change post 1.0 we will offer an easier migration...

Spin-telemetry: consider eliminating the use of `set_global_default`

> My understanding is that opentelemetry crate supports namespaced trace instrumentation, right? It should help the case I described above. Namespaced trace instrumentation would potentially help us get around setting...

Spin-telemetry: consider eliminating the use of `set_global_default`

I don't believe this is a relevant issue anymore. If you disagree please reopen this.

Provide a request ID as a header when the http trigger is triggered

My initial impression is that there isn't a ton of overlap here with WASI Observe. In the short to medium term WASI Observe is much more focused on tracing and...

Provide a request ID as a header when the http trigger is triggered

@mikkelhegn do you still feel like you have a need for this now that we have tracing?

The shim is not surfacing variable provider errors

Looks like it.

Add SIP for configuring and emitting observability

I've stripped down this SIP to cover what has already been done. I'll give a few days for review and if I don't get any engagement I'll just merge it...

Non-maintainers can't merge their own approved PRs

Who enables auto-merge? Me the non-maintainer or a maintainer who approved the PR?

Non-maintainers can't merge their own approved PRs

This seems like a reasonable conclusion for this ticket.