Caleb Cartwright

Results 710 comments of Caleb Cartwright
trafficstars

I did have a bit of a panic when I saw this report earlier today, but fortunately, the _default_ behavior is still correct and doesn't have any bearing on stable...

> Oh, sorry, didn't mean to cause a panic by underspecifying the problem. Thanks for taking a look so quickly. 🙏 np, thanks for the report!

I feel like there's too many different things being discussed on one issue to really be able to weigh in from a style perspective, and as such I don't think...

Thank you both for the work on this, just noting I've added some labels to indicate the criticality of this one as it ties into 2024 deliverables. I can help...

just checking for a status on this one, what's pending?

if there's a set of snippets where we'd like style to give a perspective then i'm happy to bring that before the team, and we do have a meeting later...

We reviewed this (the formatting improvements provided by this PR) in the t-style meeting yesterday and overall were pleased with the results. There were some thoughts on potential future improvements,...

We've been discussing this item quite a bit more in the style team meetings, and reached a decision that we only want to move forward with the indent change around...

> I’m passing source code to rustfmt on standard input, but the problem is the same if I put it in a file instead are you making those invocations sequentially...

Thank you for sharing @c02y. However, that is not correct, as those three snippets do indeed have variance with trailing commas as designed (check for the absence/presence of the trailing...