Trevor Buckner

Results 548 comments of Trevor Buckner

You are correct, we do not currently log the string positions of the tokens. You may be able to get something to work with the [`walkTokens` feature](https://marked.js.org/using_pro#walk-tokens) by tracking the...

> I think the raw member gets modified during the lexing process. This is simply merging two adjacent tokens. Occasionally we have to break a paragraph in half to check...

In fact this is another good reason to do this in `walktokens`. Some of the tokens are not completely formed when they are first added to the array, but waiting...

`raw` *should* be the complete string that was consumed by the token. I can see how some beginning or ending newlines might be miscalculated in an off-by-one error somewhere that...

Is there perhaps a good standard test Markdown document that would give Marked.js a thorough performance stress test? I know we have our bench script, but that uses only our...

@UziTech Since we run each spec 1000 times in our bench test, would it be possible to modify our bench tests to track the average time taken for each spec...

@UziTech I put together a rough version of this, but realized analyzing becomes very confusing if we are comparing 6 versions/options of Marked against Commonmark and Markdown-It. Given that, does...

Regex101 works fine. Even though the debugger is "only for PHP" they are nearly identical so it works well enough for tracking things down. Regex is always a possible source...

This seems to be in conflict with the spec: https://spec.commonmark.org/0.30/#right-flanking-delimiter-run **Edit:** Misread the spec. This indeed looks like valid markdown. I wonder if our backslash escapes are resulting in characters...

@UziTech The documentation already talks about the slugger. Do we need to add more info or clarify it somehow? Otherwise we can probably close this issue.