Bryan Chen

Results 9 comments of Bryan Chen
trafficstars

+1 for this. Is there any plan/update on this?

I agree this would also work. The logic can exist in either reducers or epics, but I think what I am trying to say is moving logic to epics would...

> Can you provide example how we can reproduce it? Thanks for the quick turnaround! I don't have a simple repro for now as my project's webpack config involves quite...

> Yep, feel free to ping me Updated with a repro, please check.

Oh good to know that, the project was originally created with create-react-app which brings in the ModuleScopePlugin at the beginning, I can try out the new setting. Regarding the error,...

For the build error I have workarounds anyway. For a fix here in RootsPlugin it seems to me that it should simply return callback() when the request.path is already a...

You mean multiple roots as in `this.roots` ? But regardless what roots we have, I think in this case the `request` has specified a rooted path, so actually we should...

> Do you think we should update the `calculateHeight` method to include this check? It's called when the content height changes or during the `componentUpdate` lifecycle of the editor component....

@alexweininger, we are from azure notebooks team and working on an extension for customer to one-click deploy a file/folder as an Azure Web App. Would like to clarify with more...