JJ Brown

Results 23 comments of JJ Brown

Hello, and thanks for looking at this PR so closely! I apologize for taking so long to reply @uwolfer . I'd be happy to implement these changes, and will submit...

Thanks for the comment, @jeremydouglass ! I thought about signature overloading (favoring `hsb()` over `hsba()`), and I agree that it's appealing. If @benfry agrees, I would be happy to edit...

Thank you for your feedback, @nibsi . I'm afraid I created the branch from my local `master` branch, which included a different change, instead of `origin/master`; I'm embarrassed I missed...

I've added some tests that cover the relevant edge cases covered by the code addition. Thank you very much for your help, @nibsi! I believe this commit is ready for...

@sf105 There's one case I can think of where the safe API is better: asserting that a null key is absent: `assertThat(new Hashtable(), not(hasKey(null)));` I would expect this to pass...

@sf105 I would be happy to make whichever further changes you think would benefit the project the best. When convenient, please let me know what further adjustments might be appropriate...

Hello again! I know it's been two years, but I've rebased this PR and would be happy to help with any further steps to get it ready for merging. @nhojpatrick...

It's hard for me to tell, but it looks like this is happening because java can't figure out the generic types. If I change the last line to: `assertThat("empty and...

I know this issue is old, but I went ahead and prepared a Pull Request that implements this proposed optimization. @tumbarumba and @nibsi, would you mind looking at this change...

I'm not certain what caused this problem for OP, but I can't reproduce this error. @kmbyrne I know it's been 3 years, but can you provide any further details about...