Brian Scholer
Brian Scholer
This could be considered a breaking change, code that worked before could stop working if `VAULT_NAMESPACE` was set before erroneously. I personally think that this being a library, it should...
> Thanks for the feedback. I don't think this can be considered a breaking change, because for an application to work correctly at this time with a namespace, it has...
> So why are we doing this for certificates then? > > https://github.com/hvac/hvac/blob/develop/hvac/constants/client.py I can't answer for the maintainers, but it seems as though the idea was to try and...
A fix for this should also close out these I think: - #293 - #385 - #660
> The only thing I don't like about returning an empty dict is that it casts to bool as False. So a condition that depends on the response of an...
As @colin-pm said, we have a more ambitious but better long-term plan for this, so I'll close this out now, and we'll be back with something new!
Following up from https://github.com/hvac/hvac/pull/767#issuecomment-926050407 here, since that's a closed issue. Thansk for opening this one! > Also, if you can expand a bit on the "broke stuff by way of...
I would like to second this request. It does indeed seem like the new method can only create orphans through the `/create` endpoint which requires a root token, so we...
Re: the implementation suggested, I wonder if there's value in re-implementing the `orphan` parameter, which seemed to work in conjunction with `no_parent`; the idea being that `no_parent` could be used...
> I would like to second this request. It does indeed seem like the new method can only create orphans through the `/create` endpoint which requires a root token, so...