Results 289 comments of Brian Scholer
trafficstars

Hi @eytanhanig , I'm trying to catch up on the outstanding PRs as I can. I'll commit to reviewing this within the next month or so (I'm traveling and will...

> What is the vault API behavior around this parameter? I notice you don't do any handling of existing metadata, no attempt at merging the updated dictionary, etc. Does vault...

I ran the following command: ```PYTHONMALLOC=debug PYTHONASYNCIODEBUG=1 python -W default -X faulthandler -m pytest tests/``` And I did not get a single warning about unclosed sockets, so something may have...

Hi @nneul ! I'd also like to apologize for the delays. I've updated your PR today to rebase it, and fix up the example so that it passes (we run...

Hi @abelmokadem thanks for opening this! I took a look at the library and I think @Tylerlhess hit the nail on the head: this is more of a library with...

Hi @amiewei , welcome! This sounds like a good approach to me, looking forward to it

Hi @gabriel-milan , The `hvac` project is simplifying its developer workflow and removing the `develop` branch. Please be aware for future PRs that the project's default branch is now `main`....

@akasurde I looked at #700 and I'm trying to figure out what the goal is here and whether to keep this issue open. Do you have any context on what...

Right now I think we're too entrenched with `requests` to support an alternate backend in the library, and our adapter system looks like it could be used in this way...