Phil Frost

Results 45 comments of Phil Frost
trafficstars

This behavior seems to originate at 263387a7. I haven't dug yet into the reasons for it, but the notion of an "errorStream" and a "warningStream" seems wrong to me. As...

I'm not familiar with the code climate format, but if it's just a matter of the appropriate syntax for errors, it would also be relatively simple to implement a small...

The answer to the "why" question should probably go in the commit log message for posterity

Sorry I haven't been keeping up with the PRs lately. I'm busy with work stuff this week but I'll try to take a look at these next week. Alternately, I'm...

Superfluous imports aren't harmless: they have (sometimes significant) performance consequences and create edges in the dependency graph that are unnecessary which can lead to dependency cycles that cause imports to...

I personally don't like to conflate my git workflow with my testing cycle, so I run it manually or [in tox](https://github.com/PyCQA/pyflakes/blob/cc2977ff8cbb0e2b668413a73a0c3a6a4b4f02e8/tox.ini#L10). [Travis](https://github.com/PyCQA/pyflakes/blob/master/.travis.yml#L17) catches any issues that make it into a...

I think for this to work, the zero point needs to be sent at the same interval as a transition from zero to non-zero would be sent. Otherwise, Wavefront will...

Looks like home-assistant [implements some part of the smart home API](https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/alexa/smart_home.py) now. I'd guess this means the Lambda function can be much simpler?

Home assistant cloud is just a dumb proxy. It's purely a convenience function: all the Smart Home API logic is in that smart_home.py file. The cloud component [publishes the protocol...

https://gist.github.com/bitglue/66ca023b3c3c1a5b267bdd1d9b3ee48f I'm working on some PRs, once I've made this cleaner.