pyflakes icon indicating copy to clipboard operation
pyflakes copied to clipboard

Use pre-commit hook with flake8 for contributors

Open toti1212 opened this issue 6 years ago • 2 comments
trafficstars

Hi there! Do you think that adds a .pre-commit hook with flake8 can be useful for contributors?

toti1212 avatar Jul 23 '19 17:07 toti1212

I personally don't like to conflate my git workflow with my testing cycle, so I run it manually or in tox.

Travis catches any issues that make it into a PR.

But if you would like to submit a configuration that makes it easier for people who do want to use pre-commit hooks to do so, without encumbering those who do not, that would be fine.

bitglue avatar Aug 08 '19 18:08 bitglue

@toti1212 is the suggestion here to create, specifically, a hook definition for use with pre-commit? I think this would meet the criteria @bitglue suggests—users could use pyflakes as a pre-commit (the tool) hook, but would not be required to in any sense.

I'd be happy to submit such a pull request if that's amenable!

daneah avatar Jul 14 '20 14:07 daneah