bids-validator

bids-validator copied to clipboard

deno testing 101: deno_tests.yml is chronically red, "on purpose"?

4

seems like just 2 tests are failing... why then to not just xfail/skip them since otherwise sounds like no point of having that CI since it would mask new fails...

yarikoptic

To support CITATION.cff we need: * [ ] Load CITATION.cff as YAML, fail if invalid * [ ] Validate with [JSON schema](https://github.com/citation-file-format/citation-file-format/blob/main/schema.json) ([raw link](https://raw.githubusercontent.com/citation-file-format/citation-file-format/main/schema.json)). We may need/want to maintain a...

effigies

Wrong error message on validation of stim file

1

This relates to this dataset: https://openneuro.org/datasets/ds000238/versions/00002 This dataset contains "stim" files: ``` /sub-01/beh/sub-01_task-test_stim.tsv.gz ``` That have several problems: - they should actually be `beh.tsv` files as they are recording suibject's...

Remi-Gau

deno run on a built bids-validator.js: Attempted to load JSON module without specifying "type"

2

Trying to run out of `deno-build` branch using wrapper proposed in - #1942 but getting ``` + bids-validator 7t_trt --ignoreNiftiHeaders TypeError: Attempted to load JSON module without specifying "type": "json"...

yarikoptic

deno: lost --config option?

3

Trying to run bids-examples tests but they use https://github.com/bids-standard/bids-examples/blob/master/bidsconfig.json file via `-c` option to ignore `99` error. Is `-c` coming to `deno` version of validator?

yarikoptic

Tests for some reason expect `/tmp/$USER` to exist?

1

```shell ❯ deno test --allow-all --coverage=cov/ src/ Check file:///home/yoh/proj/bids/bids-validator/bids-validator/src/files/browser.test.ts Check file:///home/yoh/proj/bids/bids-validator/bids-validator/src/files/deno.test.ts ... test missingLabel ... File with underscores and hyphens doesn't error out. => ./src/validators/filenameValidate.test.ts:34:11 error: NotFound: No such file...

yarikoptic

Create shim to run deno bids-validator

13

This way anyone interested to use it could just git clone --depth 1 -b deno-build http://github.com/bids-standard/bids-validator export PATH="$PWD/bids-validator:$PATH" and start using it and know which version it is: ❯ bids-validator...

yarikoptic

While working on IntendedFor problems in the examples, some datasets just need their paths updated not to have an initial `/`. Should we be strict on this, or "helpfully" remove...

effigies

https://github.com/bids-standard/bids-specification/pull/1128#discussion_r1562236022 Currently assumes all initial_columns listed in a rule are required.

rwblair

inspired by - https://github.com/bids-standard/bids-validator/issues/1930 I think we should make it very easy for PRs against bids-specification, which change schema, to run validator using modified schema against target (or all) bids-examples....

yarikoptic