bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

Published 20 hours ago • verified publisher icon bids-standard

deno testing 101: deno_tests.yml is chronically red, "on purpose"?

Open yarikoptic opened this issue 1 year ago • 4 comments
trafficstars

seems like just 2 tests are failing... why then to not just xfail/skip them since otherwise sounds like no point of having that CI since it would mask new fails ...

yarikoptic avatar Apr 18 '24 02:04 yarikoptic

Yeah, we should probably mark xfails at this point. The goal was for it not to go on so long.

effigies avatar Apr 18 '24 20:04 effigies

Nearly resolved for Ubuntu tests: https://github.com/bids-standard/bids-validator/pull/1958

Need to figure out the Mac and Windows tests.

effigies avatar Apr 26 '24 13:04 effigies

thanks -- that is great!

are those the tests on bids-examples and thus may be would allow to remove this skips I added to https://github.com/bids-standard/bids-examples/pull/435/files#diff-786f1d799afd8d7a2bd595ebff633b3683d87a556ec6abfa78bd537855ebe1a0R106 ?

yarikoptic avatar Apr 26 '24 18:04 yarikoptic

Yes, it covers all tests, including examples. Some issues on Mac and Windows.

effigies avatar Apr 26 '24 22:04 effigies