Benny Prijono

Results 14 comments of Benny Prijono

> +1 for .editorconfig, which also contains charset, end_of_line, trim_trailing_whitespace, insert_final_newline etc. They're not available on all platforms/plugins though (e.g. eclipse)

Thank you for looking into this topic. I think if we are to implement this, we'd better follow the guidelines in RFC 3261 section 8.1.3.4 and 19.1.5 regarding forming headers...

Since the URI containing the headers is taken from the 3xx response from the server, it's possible that a rouge or malfunctioning server sends invalid headers such as From, Via,...

Sorry I'm converting this to draft to resolve issues with GH CI integration. Will request for review later

There are still some CI errors to solve, but I think this PR is ready to be reviewed

> After fixing this, it's never stuck again in ~15 runs here, but occasionally (~20%) will fail with: > > ``` > 14:38:51.301 unittest.c ------------ Displaying failed test logs: ------------...

I think this is done. TODO probably as follow up PRs: - replace **all** checks with `PJ_TEST_xxx` (we'll do it later when we need to fix something in the test)...

Wholeheartedly agree on Win64 (I already wrote it as todo in my comment above). Unfortunately the pjsip/third_party_libs only has x86 as the target for most libs (some do have x64...

Win CI sometimes failed this week (it was very stable last week): 1. sleep test randomly failed (slept for more than tolerated, even with `--ci-mode`). CI machine load? 2. pjlib...

First of all, thank you for the patch submission again. This is really interesting and exciting, especially to hear that the parallel version can achieve much higher performance than the...