Benjamin Janssens

Results 27 comments of Benjamin Janssens
trafficstars

I don't think the pipeline failing is related to my changes, but feel free to let me know if I need to change anything.

@benjdlambert I'll see what I can do - I don't have much experience with writing Backstage tests, but I'll look into it :)

@benjdlambert done! Please let me know if something is still missing.

@benjdlambert ah, I see what you mean. I'm currently testing this with Bitbucket, where I didn't encounter any issues with it, but I can see the danger of it. Maybe...

Hey @acierto, yeah, I know, but I think we could add a prop to the picker component that acts as a handler for controlling the dialog. But maybe using an...

@benjdlambert @acierto I dug a little deeper and, unless I'm missing something, I noticed that we only use the host part of the URL anyways. I changed the code to...

I think the test `should call the scmAuthApi with the correct params if only a project is set` is redundant, but I don't see the connection between the title and...

@benjdlambert can you maybe take a look at this PR again? 😇

@benjdlambert I agree #16996 would be the ideal solution, but I think that might be a huge undertaking. In the meantime it could be a good idea to just "fix"...

@niallthomson you're welcome! 1. What specific code do you mean? The utils? The reason I put them in the `common` package is because I thought they were pretty domain-agnostic and...