community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

add property hideChildren to GroupsDiagram and GroupsExplorerContent

Open benjidotsh opened this issue 1 year ago • 5 comments
trafficstars

Hey, I just made a Pull Request!

I've added a property hideChildren to the GroupsDiagram and GroupsExplorerContent components. If you have a lot of groups with a lot of children and you only care about the parent groups, this can greatly improve visibility.

An example of what a GroupsDiagram looks like with hideChildren set to true:

Scherm­afbeelding 2024-04-25 om 13 15 58

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [x] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

benjidotsh avatar Apr 25 '24 11:04 benjidotsh

I don't think the pipeline failing is related to my changes, but feel free to let me know if I need to change anything.

benjidotsh avatar Apr 25 '24 11:04 benjidotsh

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-explore workspaces/explore/plugins/explore patch v0.4.21

backstage-goalie[bot] avatar May 13 '24 09:05 backstage-goalie[bot]

This looks good, is there a possibility we could add some tests here too? :pray:

benjdlambert avatar May 13 '24 09:05 benjdlambert

@benjdlambert I'll see what I can do - I don't have much experience with writing Backstage tests, but I'll look into it :)

benjidotsh avatar May 13 '24 13:05 benjidotsh

@benjdlambert done!

Please let me know if something is still missing.

benjidotsh avatar May 13 '24 14:05 benjidotsh