Benjamín Eidelman
Benjamín Eidelman
on a second thought, that's fine, if a loop is found, ignoring that branch is fine for diffing, as any difference will be detected in a parent, nice.
`objectHash` is only used among items on the same array, not with objects. that type of change seem hard to detect in a generic way, especially when changes are nested,...
correct, but you got me there, the visualization wouldn't show it as an object if you convert to array to generate the diff, I guess I was assuming, that while...
it's a good point, backward breaking changes have been very rare (or none?) so far, but would make sense to have one. re. `0.3.x`, it has no API changes, the...
@changelox thanks, I would rather not add a dependency, and rely on a simple text file.
string diffing is performed by an external lib Neil Fraser's diff-match-patch, it does a rather standard text diff, but char by char (instead of line by line likea typical git...
it might worth exploring making the text diff over words instead of chars (reducing diff granularity, but winning speed). you could achieve that by splitting the string into an array...
thanks! looks good, I'll keep this open as a reminder for future reference.
@justsml that's pretty neat, haven't seen it before, a fair comparison of multiple libs is probably the best for users. as @jdscolam I also have other test cases to suggest,...
oh I don't know about one, I'm just assuming there must be a few. but the simplest test I can think of is piping the text thru the `diff` tool...