Benjamín Eidelman
Benjamín Eidelman
Hi @Offirmo thank you!, I don't have a changelog, but should. I think I'd love to have something (PRs accepted) somewhat automatic based on the commit message convention in https://commitlint.js.org...
that's nice!, thanks, I see what you mean now, the problem is in the LCS algorithm (used when diffing arrays), I suspect LCS might be a bit too expensive for...
yes @kimptoc this ticket is still open.
hi Peter, thanks for you feedback! I don't understand the proposal, the way it's done in the demo is as you mention, with the `jsondiffpatch-unchanged` class, that wraps all context...
ah, the command line, yes makes sense.
sorry, I thought you were actually talking of jsondiffpatch CLI, but it seems you're talking about the html formatted diff, I don't get it, isn't this the same as the...
on text unidiffs? (on objects you can see the "show unchanged values" checkbox. if you mean the unidiffs, they are created by Neil Fraser's diffmatchpatch lib, not sure it has...
I see, yes, the text unidiff, those are created by https://code.google.com/archive/p/google-diff-match-patch/ but I'm not sure it has an option to do that.
hi, thanks, yes, I think it is possible to detect circular references with a plugin. jsondiffpatch walks the object tree with a linked stack, so it's possible at each node...
that looks great!, just a comment, if a loop is detected, I think I would throw an Error too, but of course, that depends on your needs.