Benjamin E. Coe

Results 554 comments of Benjamin E. Coe

Thanks for the work on this @JLHwung, I've merged the alternate PR that adds tests.

@wyp0011 any interest in submitting a patch that adds docs to the README.md with your example?

@coreyfarrell @jrgleason the ESM module implementation in Node.js completely overhauls how `require` works, and makes it so it's no longer possible to use some of nyc's tricks. we should be...

@mikeal c8 works for the subset of modules I've tested with, mind opening an issue on `c8`?

CC: @AVaksman any thoughts on this one?

@alexander-fenster @summer-ji-eng is this a use case that's supported now, by virtue of us shipping JSON versions of protos files (_am I imagining that we made this change?_).

@crwilcox @giangm9 while it can be possible to get things working, with some workarounds, we do not currently support bundlers in our gRPC libraries. There's a feature tracking thread [here](https://github.com/googleapis/google-cloud-node/issues/2933)...

In the meantime, you might have better luck with the [REST client](https://github.com/googleapis/google-api-nodejs-client).

CC: @thomasrockhu we still seem to be having some oddities with displaying reports occasionally: Seems to work for me: