Benjamin E. Coe

Results 554 comments of Benjamin E. Coe

@mf-pherlihy if any of this behavior would make sense in yargs/yargs-parser, happy to take patches.

I think this feature would be especially beneficial for exotic types like `Promise`, or `Set`, to help introduce folks to new(ish) JavaScript language features.

thanks for the suggestion @muzuiget :+1:

Agreed, seems like a reasonable request to me, @ace-n do you have a specific example of an error you were receiving so that we could see if the error was...

I'm updated this to reflect the fact that we don't support this functionality today, and should potentially consider adding this feature as an improvement to the library.

@simllll thank you for the bug report.

@simllll switched to `feature request` from `bug`, since this is requesting an addition to functionality. Would you be interested in submitting a patch for this functionality?

Making `p3`, since our intention is to drop Node 10 in 6 months.

@JustinBeckwith a warning might be enough, but I think a cleaning step that lowercases headers would be good, that way upstream libraries that build on top of gaxios, e.g., google-auth-library...

@Ricky-rick would you be open to using the `conventional-commit` parser rather than the angular parser? we're working on formally defining the parser, vs., using a series of free-form regexes: https://github.com/conventional-commits/parser...