Ben Ashbaugh

Results 432 comments of Ben Ashbaugh

Could we do this in two steps? 1. I think there are a bunch of obvious and non-contentious omissions, where `CL_UNORM_SHORT_565` and `CL_UNORM_SHORT_555` are just plain missing. Basic idea would...

There are a bunch of places in the spec that refer to "the pre-defined packed formats". Example: > read_imagef returns floating-point values in the range [0.0, 1.0] for image objects...

Interesting - I thought this wouldn't be necessary but this is changing how Clang generates code for the comparisons. @AnastasiaStulova is this expected? https://godbolt.org/z/PGPEjxj4T

Couple of thoughts and corrections: 1. There is no SPIR-V 1.7 (at least not yet!), and these updates were made in a revision to SPIR-V 1.6. I believe the change...

Discussed in the May 6th memory subgroup. If in our mental model we are creating a memory object "view" of the SVM allocation, it is more likely that the device...

PR #2147 fixed some of these tests, but there are still a few others that appear to have the same pattern, see https://github.com/KhronosGroup/OpenCL-CTS/pull/2147#pullrequestreview-2434825373. Keeping this issue open until we fix...

Here is a successful run with these changes on my fork: https://github.com/bashbaug/OpenCL-Guide/actions/runs/13148672843

Hi @starcatter, thanks again for your contribution. Do you think you will have a chance to address the review comments above? Thanks!

Yes, this is annoying... but I haven't been able to think of a good way to eliminate the duplication. FWIW, there is other duplication also, such as the tables describing...