Axel Bocciarelli

Results 216 comments of Axel Bocciarelli

Change of plan: as discussed, it might be best to consider maintaining two release branches in case some apps struggle to update to React 18. While we decide and set...

- https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-strict-mode - https://github.com/reactwg/react-18/discussions/18 Not quite sure how to work around it to still get a proper clean up. I'll investigate. Thanks! **EDIT** Actually, it's exactly the example they provide....

All good, by putting the `api` instance in a state, strict mode doesn't call the effect twice, so doesn't call the clean-up. I've also confirmed that changing the props of...

This is why `View image` rarely works: https://stackoverflow.com/a/15563621/758806 -- the rendering buffer is cleared soon after rendering for performance reasons.

The screenshot button should generate an image with the same resolution as the dataset instead of just exporting the current rendering buffer of the canvas (the "View image" context menu...

I think this is a great use case for `OffscreenCanvas` - https://developer.mozilla.org/en-US/docs/Web/API/OffscreenCanvas. The idea would be to render the heatmap in a canvas the size of the data but off...

With the `OffscreenCanvas` solution, we'll be able to remove the previous screenshot implementation, and therefore turn off `preserveDrawingBuffer` [for performance reasons](https://discoverthreejs.com/tips-and-tricks/#renderer).

Just to clarify that this issue is about generating a PNG image of the WebGL canvas as the user sees it (zoom level, color map, etc.), as opposed to #35,...