moonlander

Results 9 comments of moonlander

seconding interest in this, would be very helpful to have for kiosk-like panes which run a program directly instead of starting a shell

> Due to sign-extension of two's-complement numbers when expanding the bit-width of a negative number you will get a different bit representation if you run something like: > > `0x[f0]...

> Given that `or`, `and`, and `xor` share quite a bit of code, it may help to extract some of their shared functionality to a `util` file with a helper...

how about this? removing the call to `operate` means there is no need for an `Arguments` struct anymore for those commands, I am not sure if the same can be...

> I think you can stuff the endian processing code into the helper too (it can return a `Value::error` if the given endianness is invalid). I wanted to leave this...

just fixed, I also noticed that the endianness behavior was doing the opposite of what was expected: ``` $ 0x[ff] | bits or 0x[12 34] --endian big 0x[ff 34] $...

thanks for your patience and thorough review! I am currently working using a phone so it is not as easy to keep track of everything. hopefully it checks out now

yes, my bad not quite sure how github works so I think I did something out of order, I will see if I can fix it