Ask Solem comments

Results 158 comments of


                                            Ask Solem

Kombu filesystem transport not thread safe

It probably isn't thread safe, and that would be low on my priorities to fix

Mailbox constructor got queue and reply_queue TTL and Expires options

Looks good to me!

Mailbox constructor got queue and reply_queue TTL and Expires options

This patch should actually be applied to master, not 3.0. We use `from kombu.five import items`, iteritems is soooo Python 2. Doesn't seem like you need anything else from python-future...

Celery's broadcast() always uses the default Kombu serializer

Pidbox and celery events uses json to be compatible with other languages, and pickle is also a security concern. I don't see any reason to use a different serializer when...

Celery's broadcast() always uses the default Kombu serializer

It uses the same serializer registry as everything else. Maybe you're confused by the additional encoding used by the virtual transports? AMQP messages consists of a message body and message...

Celery's broadcast() always uses the default Kombu serializer

You can submit a pull request here at Github!

Use class-defined attributes as default values

Thanks! I'm not sure a class-level channel will ever make sense, at least it would be a terrible practice so we probably shouldn't support it. I guess a context where...

SimpleQueue.get()'s body attribute is a string when using py-amqp, but a buffer with librabbitmq

You should expect receiving a buffer from any of them, and this is good because it avoids copying the message body. I don't see how SimpleQueue.get would return that since...

SimpleQueue.get()'s body attribute is a string when using py-amqp, but a buffer with librabbitmq

.body is the raw message body, .payload is the deserialized payload that handles all of this stuff for you

Redis transport causes multiple Celery job runs if eta exceeds visibility timeout

Thanks for the detailed report! This is a known issue, mentioned in the Celery documentation: http://docs.celeryproject.org/en/latest/getting-started/brokers/redis.html#caveats I have been considering using the ETA too, but haven't had the time to...