kombu icon indicating copy to clipboard operation
kombu copied to clipboard

Mailbox constructor got queue and reply_queue TTL and Expires options

Open alanjds opened this issue 9 years ago • 12 comments

New Mailbox.__init__() options: queue_ttl, queue_expires, reply_queue_ttl and reply_queue_expires

utils.maybe_s_to_ms and utils.functional.dictfilter were copied-over from Celery implementation (from actual master)

alanjds avatar Sep 26 '16 20:09 alanjds

Coverage Status

Coverage decreased (-0.07%) to 79.595% when pulling 1f368a5b7056a6e65576286cac9d9c2bd8b1fcea on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.

coveralls avatar Sep 26 '16 20:09 coveralls

Looks good to me!

ask avatar Sep 26 '16 23:09 ask

@ask: Thank you very much. Will use this branch as the base for a PR to celery yet to be coded.

alanjds avatar Sep 27 '16 02:09 alanjds

Just a thing: I had noticed that the tests not passing are the ones for Python 3. Is desirable to the next patches to be complaint with Python 3, probable via http://www.python-future.org/ ?

alanjds avatar Sep 27 '16 02:09 alanjds

you need to get this patch pass against python3 too to be accepted.

auvipy avatar Sep 27 '16 10:09 auvipy

Ok. Will do with python-future. Ping if this is not acceptable. Thanks

alanjds avatar Sep 27 '16 15:09 alanjds

python3 support is very important at the moment :) It shouldn't be that difficult for adding python3 support

auvipy avatar Sep 27 '16 16:09 auvipy

Coverage Status

Coverage decreased (-0.003%) to 79.657% when pulling 51a5bbe290d4e3e8f212acac8646f75ad74accbe on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.

coveralls avatar Sep 28 '16 13:09 coveralls

Done :)

alanjds avatar Sep 28 '16 13:09 alanjds

Coverage Status

Coverage decreased (-0.003%) to 79.657% when pulling 8ae8d85bf2bf80be7ceadea6d0ab65acf9260905 on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.

coveralls avatar Sep 28 '16 22:09 coveralls

This patch should actually be applied to master, not 3.0.

We use from kombu.five import items, iteritems is soooo Python 2. Doesn't seem like you need anything else from python-future here.

Next major version is Python 3 only so not sure changing compatibility interface is of priority.

ask avatar Oct 05 '16 23:10 ask

Coverage Status

Coverage increased (+0.02%) to 79.683% when pulling d008cea0c1db08ff61d303f6acfeb26c033bae20 on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.

coveralls avatar Oct 13 '16 19:10 coveralls