kombu
kombu copied to clipboard
Mailbox constructor got queue and reply_queue TTL and Expires options
New Mailbox.__init__() options: queue_ttl, queue_expires, reply_queue_ttl and reply_queue_expires
utils.maybe_s_to_ms and utils.functional.dictfilter were copied-over
from Celery implementation (from actual master)
Coverage decreased (-0.07%) to 79.595% when pulling 1f368a5b7056a6e65576286cac9d9c2bd8b1fcea on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.
Looks good to me!
@ask: Thank you very much. Will use this branch as the base for a PR to celery yet to be coded.
Just a thing: I had noticed that the tests not passing are the ones for Python 3. Is desirable to the next patches to be complaint with Python 3, probable via http://www.python-future.org/ ?
you need to get this patch pass against python3 too to be accepted.
Ok. Will do with python-future. Ping if this is not acceptable. Thanks
python3 support is very important at the moment :) It shouldn't be that difficult for adding python3 support
Coverage decreased (-0.003%) to 79.657% when pulling 51a5bbe290d4e3e8f212acac8646f75ad74accbe on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.
Done :)
Coverage decreased (-0.003%) to 79.657% when pulling 8ae8d85bf2bf80be7ceadea6d0ab65acf9260905 on alanjds:pidbox-ttl into 55973ddd2af143caf919472f8b7d8e13bfbf9008 on celery:3.0.
This patch should actually be applied to master, not 3.0.
We use from kombu.five import items, iteritems is soooo Python 2. Doesn't seem like you need anything else from python-future here.
Next major version is Python 3 only so not sure changing compatibility interface is of priority.