Ashley

Results 89 comments of Ashley

@TimvdLippe will do, will take a look a little later if I have time, or if not it will be some time in the next couple of days!

@TimvdLippe at the moment I seem to be having trouble getting gradle to enable the `module-info.java` compilation path to see the other packages that are present. This might be due...

That could work, I think the main issue is getting it to compile under a different target to the rest of the classes though, without extracting it to a separate...

The only real impact is that it adds an extra layer of encapsulation. By default it will just behave as if it depends on nothing and exports all packages publically...

That sounds good! Is there any risk of it breaking Java 8 projects that link to the assertj Javadoc?

Cool, if you need any help verifying the issue with an existing project, feel free to shout and I can give it a try!

Might have to be in the morning; will set myself a reminder to take a look. Most recent one I can spot in the wild is at https://github.com/ascopes/jct/runs/6440094969?check_suite_focus=true#step:4:84 which is...

I've put a reproduction up at https://github.com/ascopes/assertj-core-2573-reproduction To reproduce locally, run `./mvnw clean package javadoc:javadoc` See https://github.com/ascopes/assertj-core-2573-reproduction/runs/6643465969 for a failed workflow run. The CI workflows for this project contain examples...

Forgot to mention, if you wish to reproduce this in integration tests, it may be worth using testcontainers or something to do this. Copying the entire repository into a container...