Asaf Mesika

Results 153 comments of Asaf Mesika
trafficstars

Your feedback is much appreciated and straight to the point. How we name the main headings as below? 1. Introduction to Pulsar using CLI 2. Introduction to Pulsar using sample...

Thanks for the detailed reply! Regarding the suggestion of moving the getting started for each role into it's own sub-section of a bigger guide (developer, operator): I was thinking about...

Ok. I'll try to combine the suggestion made above. How about we'll have 3 headings as below: * Quick-start * Developers Guide * Getting Started * Operators Guide * Getting...

I've updated the PIP according to all comments.

My plan - TOC - for the documentation site: ### Quick-start Guides 💡 The basic premise in a quick-start guide is to cater for those who want to learn by...

Sounds good. I think the correct approach would be to document it properly - exactly what you wrote above until you will fix it

I would simply change [this](https://github.com/Netflix/governator/wiki/Getting-Started#just-a-bit-more) page to say: "Make sure you import the correct class which is `com.netflix.governator.lifecycle.LifecycleManager` and not `com.netflix.governator.lifecycle.LifecycleManager` which is the internal class"

@laurit Thanks for writing this PR. I'll start by explaining the main idea standing behind this PR, compared my second draft PR: https://github.com/open-telemetry/opentelemetry-java/pull/6273 The [design](https://github.com/open-telemetry/opentelemetry-java/pull/6171#issuecomment-1938416520) I had in mind when...