Szymon Piłkowski

Results 18 comments of Szymon Piłkowski

This won't work when text is spread over multiple HTML elements/findAndReplaceDOMText's portions (and it is in my case, I've simplified it in the fiddle)

https://jsfiddle.net/q1nnnzk9/ - this should be enough for a sample

Correct me if I'm wrong, but as I understand, this would wrap the entire match and then replace the text with the capture group, which is not my goal --...

No, unfortunately it's not a fixed term; I'm generating the whole expression dynamically based on the user text selection, and working across node boundaries is the main reason I've decided...

I gave it a try -- actually the solution/hack you proposed would work in my case, even with `document` not being fixed, however, using replace as the first pass breaks...

Thanks, although hacky, this seems to help! I've noticed one more thing when testing it and created a separate issue: https://github.com/padolsey/findAndReplaceDOMText/issues/70

On the screenshot I can see that you're trying to run it without selecting any HTML code. It won't work this way, it operates on the current selection. I agree...

Good idea, thanks for the PR! I'll test tomorrow and merge is nothing explodes 💥

@fffx it's nice to see that you're building on top of my work, but please note that this extension was released under MIT license, according to which you're required to...

@fffx thanks for understanding. I think putting my name back into the LICENSE.md file and creating a separate file called AUTHORS.md listing us both (in separate lines) should be enough....