Han Li

Hi, @wilkinsona . Can this issue be assigned to me? I will align that 'server.max-http-header-size' property only for requests, and add Tomcat and Jetty-specific properties for response header size limit.

Hi @nobeh , The `JarFile#isMultiRelease` method itself already implements the relevant logic, so we don't need to do anything extra with this property. In addition, we know from the documentation...

I don't know know how to fix the problem of it. :confused: https://github.com/apache/tomcat/blob/56908dd1ec6e5a1fa46804a48463536a5f36c507/test/org/apache/coyote/http2/TestHttp2Limits.java#L60-L62

> I don't know know how to fix the problem of it. 😕 > > https://github.com/apache/tomcat/blob/56908dd1ec6e5a1fa46804a48463536a5f36c507/test/org/apache/coyote/http2/TestHttp2Limits.java#L60-L62 I found that Mark had solved a similar problem before, so I referenced his...

Will be refix according to option 3, so close this PR.

I have implemented support for RFC7239 on RemoteIpValve and RemoteIpFilter. Can anyone review my PR? I will fix timely any problems. :)

The implementation is a bit ugly, continue to optimize later, close first.

Hi @garydgregory Sorry for the late reply. The following is unit test. ```java try (final GenericObjectPool pool = new GenericObjectPool(new BasePooledObjectFactory() { @Override public String create() { return null; }...

> We can wait until you update this PR with a failing test. It is somewhat difficult to verify this through unit tests, as there is nothing to assert and...

> Then this PR won't make it because: > > * You cannot prove anything is wrong > * You have not addressed my comment on why the locking already...