Andrew Tavis McAllister
Andrew Tavis McAllister
I think doing extensions first makes sense, and does it work to do the refactor and write the test in the same PR? So we'll start with any changes that...
Working PR based tests! What are you two thinking for the next files to look into? :)
All sounds great, @vickcoo and @fabulouiOS-monk! Awesome that such key parts of the keyboards will be tested :)
Word counts via [Data/check_language_data.sparql](https://github.com/scribe-org/Scribe-iOS/blob/main/Data/check_language_data.sparql): type | total :-- | --: adjective | 4269 adverb | 107 article | 1 noun | 19748 preposition | 59 pronoun | 21 proper noun...
Note that for Hebrew we'd need to account for the fact that it's written left to right :)
Hey there @Tapo41! Thanks for expressing your interest in Scribe! 😊 First things first is depending on how knowledgable you are of [Wikidata](https://www.wikidata.org/wiki/Wikidata:Main_Page) and its query service you'd likely need...
I'd say that the [Wikipedia page on Hebrew grammar](https://en.wikipedia.org/wiki/Modern_Hebrew_grammar) would be the main place to start :) We likely don't need to look too deeply into it at the start...
@Tapo41, 96f32ab 6d27620 added the [Hebrew directory](https://github.com/scribe-org/Scribe-iOS/tree/main/Keyboards/LanguageKeyboards/Hebrew) for if you'd like to do some simple changes. A basic thing that can be done is reference the main `KeyboardViewController` in [LanguageKeyboards/Hebrew/IWKeyboardViewController.swift](https://github.com/scribe-org/Scribe-iOS/blob/main/Keyboards/LanguageKeyboards/Hebrew/HEKeyboardViewController.swift)...
Looking forward to working on this with you, @DanielGevaZA!
Thanks for the first contribution, @DanielGevaZA! Would you want to work on `HECommandVariables.swift` for the next PR? :)