Add Hebrew keyboard

[andrewtavis]

Terms

• [X] I have searched open new keyboard issues
• [X] I agree to follow Scribe-iOS' Code of Conduct
• [X] This issue is about one language, and I've changed the title to reflect this

Language support

Hebrew has tons of language data support on Wikidata and could be added soon. The language has masculine and feminine genders, and appears to conjugate verbs using first, second, and third person along with singular and plural. The 3x2 conjugation display would thus be used.

Contribution

I'd be happy to work on this, and it may be focussed on in a future release :)

What's needed

• [x] A Hebrew directory added to Keyboards/LanguageKeyboards that includes a HebrewKeyboardViewController.swift file
• [x] Hebrew language keyboard values and logic added to HEInterfaceVariables.swift in the above directory
• [x] Hebrew language keyboard commands added to HECommandVariables.swift in the above directory
• [ ] Fine tuning the WDQS queries found in Scribe-Data/Data/Hebrew
• [ ] Writing formatting Python scripts and adding them to Scribe-Data/Data/Hebrew
• [ ] Add Hebrew keyboard specific logic to KeyboardViewController.swift
• [ ] Setting up alternate key functions if there are keys that have them that aren't already implemented
• [ ] Adding all the formatted JSON data to a Data directory in the new directory and updating the data table in the readme

[andrewtavis]

Word counts via Data/check_language_data.sparql:

type	total
adjective	4269
adverb	107
article	1
noun	19748
preposition	59
pronoun	21
proper noun	872
verb	4705

[andrewtavis]

Note that for Hebrew we'd need to account for the fact that it's written left to right :)

[Tapo41]

@andrewtavis I want to work on this issue and I am new to this project. Can you share some resources on how to get started so that I can work on this issue?

[andrewtavis]

Hey there @Tapo41! Thanks for expressing your interest in Scribe! 😊

First things first is depending on how knowledgable you are of Wikidata and its query service you'd likely need to look into their introduction to the query service :) We'll need to edit the queries for Hebrew to make sure that they're getting all the words we need.

From there it all depends on what your prior experience is. Looks like you have knowledge of Python, which will be great for the data formatting. Also, do you have knowledge of Hebrew? We can definitely figure the grammar out by finding references if not :)

Thanks again for writing! 🚀

[Tapo41]

@andrewtavis can you please give me some reference to figure out the grammar as I don't have any knowledge of Hebrew

[andrewtavis]

I'd say that the Wikipedia page on Hebrew grammar would be the main place to start :) We likely don't need to look too deeply into it at the start though. Would you be interested in the Python side of things, or do you have interest in Swift for working with the iOS app?

[andrewtavis]

@Tapo41, 96f32ab 6d27620 added the Hebrew directory for if you'd like to do some simple changes. A basic thing that can be done is reference the main KeyboardViewController in LanguageKeyboards/Hebrew/IWKeyboardViewController.swift as it's referenced in the keyboard view controllers for other languages :) From there you could make the files HEInterfaceVariables.swift and HECommandVariables.swift and we could start adding the language logic into them 😊

[DanielGevaZA]

I'm happy to work on this :)

[andrewtavis]

Looking forward to working on this with you, @DanielGevaZA!

[DanielGevaZA]

Completed the needed edits in HEInterfaceVariables. Will create a PR and we can take it from there. Good progress so far!

[andrewtavis]

Thanks for the first contribution, @DanielGevaZA! Would you want to work on HECommandVariables.swift for the next PR? :)