Matt Joiner

Results 788 comments of Matt Joiner

I'm not sure about this one. I don't think channels are a good way to handle events unless there's explicit concurrency cooperation required. In the case here where we are...

Sorry for the delay on this. I think you're heading in my preferred direction. Let me know if you want the whole PR reviewed. Thanks for your fantastic contributions

I'll check it out thoroughly shortly. If the CI fixes are missing I'll merge them in unless someone beats me to it.

There's a few changes I'd make but I don't want to block this further. I'll sort them out if it comes up as an issue.

I think some data races slipped through on this one.

Fixed in https://github.com/anacrolix/torrent/commit/28651a4ae25e7e99c2e54eebc064f4eed288b850.

Are you interested in refactoring it a bit (totally fine if not). I think we could move the LPD stuff into a separate package, probably just `./lpd`, or `bep14` or...

There are some race conditions. Run the tests with -race on your system.

This is looking very good, thanks for taking feedback on board. I'll give a more detailed response shortly.