Kartik Ohri

Results 54 comments of Kartik Ohri

On hold, because intend to fix with LB-1118

Just to clarify, `_asdict()` is named like a private member but isn't one. Its intended for public use but has been named with an _ for "reasons".

Thanks for adding the new tests. Those look good to me. But the unresolved comment above to add an assert for success alert still needs to fixed.

At a quick look, these changes need to be made for the api as well?

AFAIR, CB doesn't update the MusicBrainz usernames when the MB username is updated. We should probably add that (separate PR is fine) as well so that when MB username changes,...

I have put this PR up on test/beta for testing but its likely issues will only appear in constant submission of listens. How about we put this up on spotify...

> Dump parquet for users who want this in spark or other tools Almost all tools including spark support importing from CSV so I guess good enough for now or...

@corydolphin We want to use Flask-CORS in our app and this feature is useful to us as well. I am interested in submitting a PR for this enhancement. What should...

@corydolphin Hi! Apologies I was busy elsewhere earlier and only remembered about this recently. I have opened a PR for this issue now.