Kartik Ohri

Results 54 comments of Kartik Ohri

This is not the right way to check for various artists. Various artists releases have the special artist_credit_id of 1. So ac.id = 1 in the where clause would work.

I would suggest doing this filtering on frontend instead so that users have the option to show/hide va releases.

(doesn't depend on #15011 but includes changes from it due to local migrations and testing)

Indeed but `DROP INDEX` requires the `ACCESS EXCLUSIVE` lock in Postgres so best to remove at same time as `pending` column.

The pending field in backups also needs to be handled, should I update backups to remove pending field from Unit and include PendingUnitChange in dumps as well?

Sounds good to me, let me know if any other changes are needed meanwhile. Or if you feel there are missing test cases that should be added to the test...

@MonkeyDo Is it fine to merge this PR? The export issues are because of the soundcloud data and I will resolve them separately.