Alay Patel
Alay Patel
It looks like the model will directly be converted into domain xml and none of the in-tree controllers are using the enum value of that field. Seems like the api...
@EdDev one of the thoughts that came to mind while looking at this PR was that api-conventions suggest using type aliases to string https://github.com/kubernetes/api/blob/master/core/v1/types.go#L6104 for enums. The enum here is...
I'm okay with this with a caveat that this should not be used as an example to move features in beta after release retroactively. We could make an exception for...
/lgtm Thanks @Sreeja1725
/cherry-pick release-1.3
@lyarwood yes there are a bunch of steps needed for getting the instance types metrics, your help will be very much appreciated. I think the best way would be to...
/retest-required
@xpivarc / @lyarwood someone needs to give this PR an approve tag. Please take a look, thanks
@xpivarc the release benchmarks will not change since the fix will show data for 1.4 code due to branching. We don't have the ability to run on release branches yet.