Alay Patel

Results 100 comments of Alay Patel
trafficstars

cc @brianmcarey Is there a way to test the changes in CI?

replaces https://github.com/kubevirt/kubevirt/pull/11131

@oshoval can you elaborate more about the script? Where will it live? How will it be invoked in CI?

@oshoval it is not desirable to have a script in kubevirt since these manifests don't age well. Instead this was the preferred option. Adding @brianmcarey for now thoughts on this.

> question is if it can be done all in a standalone file, with manifests downloaded ad hoc according version ? imho if so, kubevirt fits better but i see...

@brianmcarey apologies for latency. Added 1.28 and 1.30 providers.

> Also would it make sense to KUBEVIRT_DEPLOY_KWOK=true to check-cluster-up.sh as it is done here for prometheus - @brianmcarey I have added a separate commit to set this variable to...

@brianmcarey addressed both the comments, PTAL

not sure why the 1.30 job continuously fails. Seems unrelated to the changes in the PR

@aburdenthehand hey I am considering the implications of what will break with removal of this feature. The usecase being considered is a KubeVirt stack installed with gpu-device plugins. The device...