Alexey Ivanov
Alexey Ivanov
Thank you, @magicus, I should've noted the changes and created a branch on top of yours. That's right. Even looking through all the changes in this PR was tedious, more...
> Please exclude ALL 3rd party libraries from this PR. Are these the only files to be excluded? ``` src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c src/java.desktop/share/native/libfreetype/src/autofit/afcjk.c src/java.desktop/share/native/libfreetype/src/autofit/aflatin.c src/java.desktop/share/native/libfreetype/src/base/ftsynth.c src/java.desktop/share/native/libfreetype/src/raster/ftraster.c ```
Swing supports [CSS1](https://www.w3.org/TR/REC-CSS1/) only, it defines color names for [16 colors](https://www.w3.org/TR/REC-CSS1/#color-units): > The suggested list of keyword color names is: aqua, black, blue, fuchsia, gray, green, lime, maroon, navy, olive,...
I've submitted a test job with this fix. Should it be an enhancement?
> > Are you talking about [#9825 (comment)](https://github.com/openjdk/jdk/pull/9825#issuecomment-1216011827)? > > @SWinxy Yes, only because the result is publicly exposed : `stringToColor` is also used by `javax.swing.text.html.StyleSheet stringToColor` method to publicly...
> > Should it be an enhancement? > > corrects or changes `Orange` value in (bug ?) It's probably a bug. `'Orange'` shouldn't have been there. Both [HTML 3.2](https://www.w3.org/TR/2018/SPSD-html32-20180315/#body) and...
> > ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main) request for issue [JDK-8292276](https://bugs.openjdk.org/browse/JDK-8292276) with the correct fix version. This pull request cannot be integrated until the CSR request is approved. > >...
> "JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color" #10317 could affect this specifications too. That's right. So you should take it into account. The updated javadoc...
> > Shall I edit the subject of the issue to be more specific? “Add named colors from CSS Color Module Level 4”? > > Yes, you may. Thanks. I...