Anthony
Anthony
@adamjstewart also, the other part to this discussion that @stsewd and i had about this change: core team discussed these changes a while back and came to the conclusion that...
@nienn might have some thoughts here. One additional requirement might be screenshot output, or something reviewable by community members. We can always give community members access to our saucelab/etc account...
I built out a QA test site on one of our staging S3 buckets: https://readthedocs-static-dev.s3.us-east-2.amazonaws.com/qa/theme/index.html This is currently manually updated and doesn't include PR builds. It's reachable by Saucelabs however....
You can try again with `1.0.0rc1`, it's not clear that there is a bug with the theme here. If anything, you're probably noticing an issue with Sphinx HTML4 vs HTML5,...
This doesn't seem like the correct approach, as the line length is specific to readability and usability. A more correct fix would be altering the font size with screen size...
This isn't a bug of the theme, it was done on purpose. The reason behind strict width is that reading comprehension drops when having to parse a long line like...
This is another design decision to get back to, probably. Based on our most recent conversations, our badge flyout version selector menu is actually going to move outside the theme....
I would downgrade Node. There are issues between Node, node-gyp, and Python 3. See https://github.com/readthedocs/sphinx_rtd_theme/pull/771 for some background, though no particular fix there.
For comparison, I have node 10.5 set in my environment.
I fixed a number of issues that have piled up and have working builds at #1316. All errors were due to upgraded dependencies. #1314 addresses the Node version, which is...