CI is failing

[astrojuanlu]

trafficstars

On #1274 I see a build failure that seems totally unrelated:

npm ERR! ../src/binding.cpp:358:1: note: in expansion of macro ‘NODE_MODULE’
npm ERR!   358 | NODE_MODULE(binding, RegisterModule);
npm ERR!       | ^~~~~~~~~~~
npm ERR! make: *** [binding.target.mk:133: Release/obj.target/binding/src/binding.o] Error 1
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/home/circleci/project/node_modules/node-gyp/lib/build.js:262:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
npm ERR! gyp ERR! System Linux 5.11.0-1022-aws
npm ERR! gyp ERR! command "/usr/local/bin/node" "/home/circleci/project/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
npm ERR! gyp ERR! cwd /home/circleci/project/node_modules/node-sass
npm ERR! gyp ERR! node -v v16.13.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok 
npm ERR! Build failed with error code: 1

as well as tons of warnings.

[agjohnson]

I would downgrade Node. There are issues between Node, node-gyp, and Python 3.

See https://github.com/readthedocs/sphinx_rtd_theme/pull/771 for some background, though no particular fix there.

[agjohnson]

For comparison, I have node 10.5 set in my environment.

[ctb]

the circleci jobs have been failing for what looks like months - https://app.circleci.com/pipelines/github/readthedocs/sphinx_rtd_theme - seems like it continues to be caused by this issue.

[agjohnson]

I fixed a number of issues that have piled up and have working builds at #1316. All errors were due to upgraded dependencies. #1314 addresses the Node version, which is the error above.

[ctb]

(thank you!!!)