Adrian Li

Results 117 comments of Adrian Li
trafficstars

@wbnns It's my understanding that files in the `contrib` folder aren't actually part of the book and that a lot of them are files to be potentially included. I think...

@wbnns thanks for the merge > Just to confirm, are you all still in the process of reviewing code/truffle/*? I'm waiting to see when #962 gets merged in. Since 0.6...

Just pointing out that I am no longer associated with Truffle, but I am happy to keep helping with the book.

@wbnns I think we should make a decision on @HAOYUatHZ's issue first: https://github.com/ethereumbook/ethereumbook/pull/962#issuecomment-611265378

@chanhosuh I want to do it after all the code has been upgraded to 0.6. (e.g. when #962 is merged). Not sure why it's not merged yet though? @HAOYUatHZ @wbnns...

@chanhosuh agreed, those can definitely be gitignored.

To add on to this, how do I import types like `Block` and `Network`. They seem to be internal to Ethers.

Image should be replaced with a smaller file: ![react-reveal-text](https://cloud.githubusercontent.com/assets/943555/21519497/988cbd5c-ccbb-11e6-9fa0-1911f133de61.gif) EDIT: done.

My NPM version is `5.5.1` and I still had this issue. Jordan's workaround above worked fine though.

@jordwalke I was using official npm release `5.5.1` on Mac OS `10.12.6` Sierra. Willing to try other combinations if you'd like.